Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #4282 -- Made startapp/startproject management commands honor umask. #15102

Merged
merged 1 commit into from Nov 24, 2021

Conversation

awtimmering
Copy link
Contributor

Co-authored-by: c.schmitt@briefdomain.de

@awtimmering
Copy link
Contributor Author

@awtimmering awtimmering marked this pull request as ready for review November 21, 2021 13:31
@awtimmering awtimmering changed the title Fixes #4282 - project/app creation to honor umask Fixed #4282 - project/app creation to honor umask Nov 22, 2021
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awtimmering Thanks for this patch 👍 I left initial comments.

tests/admin_scripts/tests.py Outdated Show resolved Hide resolved
tests/admin_scripts/tests.py Outdated Show resolved Hide resolved
tests/admin_scripts/tests.py Outdated Show resolved Hide resolved
tests/admin_scripts/tests.py Outdated Show resolved Hide resolved
tests/admin_scripts/tests.py Outdated Show resolved Hide resolved
django/core/management/templates.py Outdated Show resolved Hide resolved
Copy link
Member

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with other reviewers
Lazy is my second name!

@felixxm felixxm changed the title Fixed #4282 - project/app creation to honor umask Fixed #4282 -- Made startapp/startproject management commands honor umask. Nov 24, 2021
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awtimmering Thanks for updates 👍

I pushed small edits.

django/core/management/templates.py Outdated Show resolved Hide resolved
…onor umask.

Co-authored-by: Christian Schmitt <c.schmitt@briefdomain.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants