Fixed #33301 -- Clarified the type of arguments required by custom assertions. #15106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmispelon
force-pushed
the
ticket-33301-doc-assertformerror
branch
from
07140c7
to
c271a67
Compare
kezabelle
reviewed
Nov 22, 2021
kezabelle
reviewed
Nov 22, 2021
…ors() raise ValueError for non test client responses.
felixxm
force-pushed
the
ticket-33301-doc-assertformerror
branch
from
cdc5a21
to
9ac92b1
Compare
felixxm
reviewed
Nov 26, 2021
tests/test_utils/tests.py
Outdated
| response = HttpResponse() | ||
|
|
||
| with self.assertRaisesMessage(ValueError, msg): | ||
| self.assertFormsetError(response, 'formset', 0, 'field', "invalid value") |
There was a problem hiding this comment.
Suggested change
| self.assertFormsetError(response, 'formset', 0, 'field', "invalid value") | |
| self.assertFormError(response, 'form', 'field', 'invalid value') |
tests/test_utils/tests.py
Outdated
| response = HttpResponse() | ||
|
|
||
| with self.assertRaisesMessage(ValueError, msg): | ||
| self.assertFormError(response, 'form', 'field', "invalid value") |
There was a problem hiding this comment.
Suggested change
| self.assertFormError(response, 'form', 'field', "invalid value") | |
| self.assertFormsetError(response, 'formset', 0, 'field', 'invalid value') |
felixxm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.