Fixed #33406 -- Avoided creation of MaxLengthValidator(None) when resolving Value.output_field for strings. #15277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezabelle
force-pushed
the
tickets/33406
branch
from
d015b9a
to
68f88b9
Compare
felixxm
changed the title
|
@kezabelle Thanks 👍 |
…olving Value.output_field.
…olving Value.output_field for strings. This brings the behaviour in line with Field subclasses which append to the validators within __init__(), like BinaryField, and prevents the creation of a validator which incorrectly throws a TypeError, if it were used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket is 33406 - 'Micro-optimisation for Value._resolve_output_field (by modifying CharField.__init__)'
This brings the behaviour in line with
Fieldsubclasses which append to the validators within__init__, likeBinaryField, and prevents the creation of a validator which incorrectly throws aTypeError, if it were used.Locally this benchmarks as saving roughly
2µsper invocation; see ticket for full examples.Lets see if the tests pass, given I've had to pull and rebase and haven't tested beyond the default sqlite runtests.