Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed malformed attribute directives in docs. #15284

Merged
merged 2 commits into from Jan 5, 2022
Merged

Conversation

smithdc1
Copy link
Member

@smithdc1 smithdc1 commented Jan 4, 2022

I think the two attribute changes are fairly straight forward.

While looking for other cases I found the comment one, not sure what this was intended for but it's been there for about a decade and doesn't show in the docs. Therefore I thought we could remove it?

I've put as two separate commits so the second one can be dropped/squashed as needed.

Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks 👍🏻

I checked for other missing colons using git grep -E '\.\. attribute:[^:]' -- docs/ and only found the two you've fixed.
I also agree with your removal of the .. comment (there are no other usage of .. comment in the docs).

@felixxm felixxm changed the title Fixed incorrect directives in docs Fixed malformed attribute directives in docs. Jan 5, 2022
@felixxm
Copy link
Member

felixxm commented Jan 5, 2022

@smithdc1 Thanks 👍

@felixxm felixxm merged commit 973fa56 into django:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants