Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #33543 -- Deprecated passing nulls_first/nulls_last=False to OrderBy and Expression.asc()/desc(). #15682

Merged
merged 1 commit into from May 12, 2022
Merged

Fixed #33543 -- Deprecated passing nulls_first/nulls_last=False to OrderBy and Expression.asc()/desc(). #15682

merged 1 commit into from May 12, 2022

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented May 11, 2022

ticket-33543

Thanks Allen Jonathan David for the initial patch.

@felixxm felixxm mentioned this pull request May 11, 2022
Closed
@felixxm felixxm requested a review from a team May 11, 2022 08:26
kezabelle
kezabelle reviewed May 11, 2022
View reviewed changes
docs/releases/4.1.txt Outdated Show resolved Hide resolved
hramezani
hramezani approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timgraham timgraham changed the title Fixed #33543 -- Depracated passing nulls_first/nulls_last=False to OrderBy and Expression.asc()/desc(). Fixed #33543 -- Deprecated passing nulls_first/nulls_last=False to OrderBy and Expression.asc()/desc(). May 11, 2022
@felixxm
Fixed #33543 -- Deprecated passing nulls_first/nulls_last=False to Or…
5cb9843 
…derBy and Expression.asc()/desc().

Thanks Allen Jonathan David for the initial patch.
kezabelle
kezabelle approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@kezabelle kezabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third pass, I've found nothing :)

@felixxm
Copy link
Member Author

felixxm commented May 12, 2022

Thanks for reviews 👍

@felixxm felixxm merged commit 68da6b3 into django:main May 12, 2022
@felixxm felixxm deleted the issue-33543 branch May 12, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezabelle kezabelle kezabelle approved these changes

@hramezani hramezani hramezani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@felixxm @kezabelle @hramezani