Fixed #33028 -- Used ModelAdmin's opts attribute instead of model._meta.

[mgaligniana]

Ticket ModelAdmin.init has self.opts, but it still nowerewhere else in django.admin.contrib.options not used

As the ticket mentions I cleaned up just the django/contrib/admin/options.py file and the two classes that inherit from ModelAdmin (ActionAdmin and UserAdmin)

I found other files where self.model._meta is used without define a self.opts. If you think it's worth it I can do it in a different commit or PR or new ticket!

Thanks!

[felixxm]

I found other files where self.model._meta is used without define a self.opts. If you think it's worth it I can do it in a different commit or PR or new ticket!

I don't think it's worth changing, _meta is heavily used in Django internals and there is nothing wrong with that. In the ModelAdmin we have self.opts already defined so using it's more natural than refetching self.model._meta.

[felixxm]

@mgaligniana Thanks 👍 I found few more cases:

• _changeform_view():
  

  django/django/contrib/admin/options.py

  Lines 1759 to 1760 in 2887b9f

  	model = self.model
  	opts = model._meta

• history_view():
  

  django/django/contrib/admin/options.py

  Lines 2183 to 2194 in 2887b9f

  	model = self.model
  	obj = self.get_object(request, unquote(object_id))
  	if obj is None:
  	return self._get_obj_does_not_exist_redirect(
  	request, model._meta, object_id
  	)
  	if not self.has_view_or_change_permission(request, obj):
  	raise PermissionDenied
  	# Then get the history for this object.
  	opts = model._meta

• get_formset():
  

  django/django/contrib/admin/options.py

  Line 2408 in 2887b9f

  "class_name": self._meta.model._meta.verbose_name,

[mgaligniana]

I couldn't figure out how replace the last case: get_formset(): when does self._meta.model._meta.verbose_name as it's inherit from ModelForm

[felixxm]

@mgaligniana Thanks for updates 👍

I couldn't figure out how replace the last case: get_formset(): when does self._meta.model._meta.verbose_name as it's inherit from ModelForm

Yes, my mistake.