Fixed #12756: Improved error message when yaml module is missing. #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test makes sure an YAML import errors are communicated to the caller rather than stating the serializer does not exist.
The serializer definitely exists, but the dependent yaml module may not be installed. The register_serializer() function will catch exceptions and will stub in a fake serializer object that will raise the exception when the serializer is used.
Moved the get_serializer() call within the condition that checks public serializers. This will allow exceptions other than SerializerDoesNotExist to be raised in order to provide the caller with useful information, e.g when pyyaml is not installed.
In order to verify the behavior of using the yaml serializer when yaml is on the system, fake the ImportError when the serializer is being registered.
When a BadSerializer instance is stubbed in for the yaml serializer, make sure tests do not fail.
|
This PR replaces #1564. |
freakboy3742
added a commit
that referenced
this pull request
Sep 6, 2013
…r-error-message Fixed #12756: Improved error message when yaml module is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running dumpdata without
pyyamlinstalled will now produce a useful error message: