Fixed #33966 -- Added support for using KeyTextTransform from lookup. #16016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Sep 5, 2022
felixxm
reviewed
Sep 14, 2022
There was a problem hiding this comment.
@AllenJonathan Thanks 👍 I left comments, please add also a release note.
django/db/models/fields/json.py
Outdated
| def from_lookup(cls, lookup): | ||
| transform, *keys = lookup.split(LOOKUP_SEP) | ||
| if not keys: | ||
| raise ValueError("Missing keys") |
There was a problem hiding this comment.
Suggested change
| raise ValueError("Missing keys") | |
| raise ValueError("lookup cannot be empty.") |
There was a problem hiding this comment.
Providing a non-empty lookup - giving only transform would produce this error. Wouldn't this be incorrect?
There was a problem hiding this comment.
Right, maybe "lookup must contains key or index transforms." 🤔 .
|
Just the error needs discussion. I've made all the other suggested changes. |
felixxm
changed the title
|
@AllenJonathan Thanks 👍 |
felixxm
force-pushed
the
ticket_33966
branch
from
74923ff
to
81390b7
Compare
felixxm
force-pushed
the
ticket_33966
branch
from
81390b7
to
1017819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.