Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NPM lock file to git ignore. #16031

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ tests/coverage_html/
tests/.coverage
build/
tests/report/
package-lock.json
5 changes: 3 additions & 2 deletions docs/internals/contributing/writing-code/javascript.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ Code style
conform to the code style of each file.

* Use the `ESLint`_ code linter to check your code for bugs and style errors.
ESLint will be run when you run the JavaScript tests. We also recommended
installing a ESLint plugin in your text editor.
ESLint will be run with :ref:`pre-commit <coding-style-pre-commit>` and when
you run the JavaScript tests. We also recommended installing a ESLint plugin
in your text editor.

* Where possible, write code that will work even if the page structure is later
changed with JavaScript. For instance, when binding a click handler, use
Expand Down