Fixed 34039 - added min-width to the admin searchbar on small devices. #16091
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
|
@clytaemnestra Thanks for this patch 👍 As far as I'm aware, we should stretch the entire block not only the search bar to get: instead of
|
There was a problem hiding this comment.
🌈 tested in Firefox 104, Chrome 92, Ubuntu 20.04 – and Safari 15.6.1 macOS 12.5.1
@felixxm we ended up only fixing the width of the input, not whether or not the whole toolbar (and its background) spans the whole of the screen or not. This whole flexbox implementation is a bit harder to work on.
If we want to fix the toolbar’s background taking up the whole width – could we make that as a separate ticket?
|
Tests are fixed. @felixxm I created another ticket for that issue: https://code.djangoproject.com/ticket/34047, as agreed above. I could pick it up and check it out, once it's approved. |
|
@thibaudcolas Due to the fact that fixing #16091 is complicated with the current HTML structure, maybe it would be better to close ticket-34047 as a duplicate and fixed both issues together. What do you think? |
|
Closing due to inactivity. |
Fix for: https://code.djangoproject.com/ticket/34039.