New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #34038 -- Improve link readability and identifiability #16101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. This looks good, but I think we can remove the hover style, I think it looks better without and doesn't provide much value IMO.
@CLWilliam Do you have time to keep working on this? (see #16101 (review)) |
@felixxm it's on the menu for this evening! |
@thibaudcolas Can you take a look? |
@@ -24,7 +24,7 @@ html[data-theme="light"], | |||
--breadcrumbs-link-fg: var(--body-bg); | |||
--breadcrumbs-bg: var(--primary); | |||
|
|||
--link-fg: #447e9b; | |||
--link-fg: #437c98; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new color have enough contrast when the background is white. Unfortunately --link-fg
is also used with yellow (#ffffcc
) and gray backgrounds (#f8f8f8
). We should make it even darker to meet AA standards, e.g. #417893
(\cc @knyghty.)
Closing due to inactivity. |
To improve the readability of links in the Django admin: