Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used super().execute/executemany() in SQLiteCursorWrapper. #16270

Merged
merged 1 commit into from
Nov 8, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions django/db/backends/sqlite3/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -371,11 +371,11 @@ class SQLiteCursorWrapper(Database.Cursor):

def execute(self, query, params=None):
if params is None:
return Database.Cursor.execute(self, query)
return super().execute(query)
# Extract names if params is a mapping, i.e. "pyformat" style is used.
param_names = list(params) if isinstance(params, Mapping) else None
query = self.convert_query(query, param_names=param_names)
return Database.Cursor.execute(self, query, params)
return super().execute(query, params)

def executemany(self, query, param_list):
# Extract names if params is a mapping, i.e. "pyformat" style is used.
Expand All @@ -386,7 +386,7 @@ def executemany(self, query, param_list):
else:
param_names = None
query = self.convert_query(query, param_names=param_names)
return Database.Cursor.executemany(self, query, param_list)
return super().executemany(query, param_list)

def convert_query(self, query, *, param_names=None):
if param_names is None:
Expand Down