Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34199 -- Added example to StringAgg docs. #16356

Merged
merged 2 commits into from Dec 5, 2022
Merged

Fixed #34199 -- Added example to StringAgg docs. #16356

merged 2 commits into from Dec 5, 2022

Conversation

sdolemelipone
Copy link
Contributor

As there wasn't any. Also thought it would be useful to have a ManyToMany example.

shangxiao
shangxiao suggested changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@shangxiao shangxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that looks useful ❤️

There's a typo that needs fixing though before handing over to felixx.

docs/ref/contrib/postgres/aggregates.txt Outdated Show resolved Hide resolved
@shangxiao
Copy link
Contributor

Nitpick: also may want to clarify in the commit message that it's adding an example to the docs, ie not adding documentation 🤔

@sdolemelipone sdolemelipone changed the title Fixed #34199 -- Added documentation for StringAgg Fixed #34199 -- Added example for StringAgg Dec 3, 2022
@sdolemelipone
Copy link
Contributor Author

Nitpick: also may want to clarify in the commit message that it's adding an example to the docs, ie not adding documentation thinking

Corrected!

@sdolemelipone
Copy link
Contributor Author

Just fixed another minor typo....sorry, I'm done making changes now! :-)

@felixxm felixxm changed the title Fixed #34199 -- Added example for StringAgg Fixed #34199 -- Added example to StringAgg docs. Dec 5, 2022
@felixxm
Copy link
Member

felixxm commented Dec 5, 2022

@sdolemelipone Thanks 👍

@felixxm felixxm merged commit 3445938 into django:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangxiao shangxiao shangxiao requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sdolemelipone @shangxiao @felixxm