Refs #33308 -- Modernized database wrapper in the PostgreSQL backend. #16362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Used connection.info instead of connection.get_parameter_status() and connection.server_info which don't exist in psycopg 3. - Set encoding using the client_encoding connection parameter instead of connection.set_client_encoding() that doesn't exist in psycopg 3. - Used the dbname connection parameter instead of deprecated alias - database.
11 tasks
|
Merged in 6a21658. |
andersk
reviewed
Apr 7, 2023
| @@ -186,16 +186,16 @@ def get_connection_params(self): | |||
| self.ops.max_name_length(), | |||
| ) | |||
| ) | |||
| conn_params = {} | |||
| conn_params = {"client_encoding": "UTF8"} | |||
There was a problem hiding this comment.
This value is never used because conn_params is unconditionally overwritten below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connection.infoinstead ofconnection.get_parameter_status()andconnection.server_infowhich don't exist inpsycopg3.client_encodingconnection parameter instead ofconnection.set_client_encoding()that doesn't exist inpsycopg3.dbnameconnection parameter instead of deprecated alias -database.