Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoided direct mocking of psycopg2.__version__ in test_correct_extraction_psycopg2_version(). #16371

Merged
merged 1 commit into from Dec 8, 2022
Merged

Avoided direct mocking of psycopg2.__version__ in test_correct_extraction_psycopg2_version(). #16371

merged 1 commit into from Dec 8, 2022

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Dec 8, 2022

No description provided.

@felixxm felixxm mentioned this pull request Dec 8, 2022
Merged
11 tasks
@felixxm felixxm requested a review from a team December 8, 2022 12:31
claudep
claudep approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hramezani
hramezani approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

carltongibson
carltongibson approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I guess... (/me 🤯 with the imports but...)

@felixxm
Copy link
Member Author

felixxm commented Dec 8, 2022

Thanks for reviews 🌟

@felixxm felixxm merged commit 9da2210 into django:main Dec 8, 2022
@felixxm felixxm deleted the test_correct_extraction_psycopg_version branch December 8, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

@claudep claudep claudep approved these changes

@hramezani hramezani hramezani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@felixxm @carltongibson @claudep @hramezani