Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34208 -- Confirmed support for GDAL 3.6. #16409

Merged
merged 1 commit into from Dec 29, 2022
Merged

Fixed #34208 -- Confirmed support for GDAL 3.6. #16409

merged 1 commit into from Dec 29, 2022

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Dec 29, 2022

felixxm
felixxm commented Dec 29, 2022
View reviewed changes
docs/ref/contrib/gis/install/geolibs.txt
Comment on lines -233 to -236
Because GeoDjango has its own Python interface, the preceding instructions
do not build GDAL's own Python bindings. The bindings may be built by
adding the ``--with-python`` flag when running ``configure``. See
`GDAL/OGR In Python`__ for more information on GDAL's bindings.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note was outdated, see GDAL docs.

felixxm
felixxm commented Dec 29, 2022
View reviewed changes
docs/ref/contrib/gis/install/geolibs.txt

Configure, make and install::
For GDAL 3.6.x and greater, releases only support builds using ``CMake``. To
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See release notes: "CMake is the only build system available in-tree. autoconf and nmake build systems have been removed".

@felixxm felixxm requested a review from a team December 29, 2022 07:31
smithdc1
smithdc1 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@smithdc1 smithdc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I checked with:

gdal                      3.6.1          
geos                      3.11.1          
libspatialite             5.0.1           
libsqlite                 3.40.0     
proj                      9.1.1

@felixxm
Copy link
Member Author

felixxm commented Dec 29, 2022

Thanks both 🎆

@felixxm felixxm merged commit ecbb5db into django:main Dec 29, 2022
@felixxm felixxm deleted the issue-34208 branch December 29, 2022 10:36
@icemac icemac mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngnpope ngnpope ngnpope approved these changes

@smithdc1 smithdc1 smithdc1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@felixxm @ngnpope @smithdc1