Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #33783 -- Added IsEmpty GIS database function and __isempty lookup on PostGIS. #16415

Merged
merged 1 commit into from Jan 3, 2023
Merged

Fixed #33783 -- Added IsEmpty GIS database function and __isempty lookup on PostGIS. #16415

merged 1 commit into from Jan 3, 2023

Conversation

claudep
Copy link
Member

@claudep claudep commented Dec 31, 2022

No description provided.

@felixxm felixxm changed the title Fixed #33783 -- Added the IsEmpty GIS function with PostGIS support. Fixed #33783 -- Added ExtractIsoYear GIS database function and __isempty lookup on PostGIS. Jan 2, 2023
@felixxm felixxm changed the title Fixed #33783 -- Added ExtractIsoYear GIS database function and __isempty lookup on PostGIS. Fixed #33783 -- Added IsEmpty GIS database function and __isempty lookup on PostGIS. Jan 2, 2023
felixxm
felixxm reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claudep Thanks 👍

I added support for __isempty lookup and made some doc changes.

tests/gis_tests/geoapp/test_functions.py Outdated Show resolved Hide resolved
django/contrib/gis/db/models/functions.py Outdated Show resolved Hide resolved
@felixxm felixxm force-pushed the 33783 branch 2 times, most recently from 9d13220 to ab946b2 Compare January 2, 2023 12:02
@claudep
Copy link
Member Author

claudep commented Jan 2, 2023

Thanks, looks good! However, the link between this patch and the test_make_line failures is not obvious 😬 Tell me if you need help.

@felixxm
Copy link
Member

felixxm commented Jan 2, 2023

Thanks, looks good! However, the link between this patch and the test_make_line failures is not obvious grimacing Tell me if you need help.

It seems that the new tests have broken the shaky balance of the default ordering :) (see ticket-23842.)

@felixxm
Copy link
Member

felixxm commented Jan 2, 2023

Thanks, looks good! However, the link between this patch and the test_make_line failures is not obvious grimacing Tell me if you need help.

It seems that the new tests have broken the shaky balance of the default ordering :) (see ticket-23842.)

I've tried to fix it, see #16419.

@felixxm felixxm merged commit 2a14b8d into django:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@claudep @felixxm