Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34266 -- Added ClosestPoint GIS database functions. #16449

Merged
merged 1 commit into from Jan 20, 2023
Merged

Fixed #34266 -- Added ClosestPoint GIS database functions. #16449

merged 1 commit into from Jan 20, 2023

Conversation

niccolomineo
Copy link
Contributor

@niccolomineo niccolomineo commented Jan 13, 2023 •
edited

I'd like to suggest adding this function to the bunch to encourage people to prefer its use in a number of situations over cumbersome solutions.

@pauloxnet
Copy link
Contributor

Please add references to this new feature in the documentation as well especially in:

https://github.com/django/django/blob/main/docs/ref/contrib/gis/functions.txt

and

https://github.com/django/django/blob/main/docs/ref/contrib/gis/db-api.txt

See a similar function for reference.

emarhin
emarhin approved these changes Jan 14, 2023
View reviewed changes
Copy link

@emarhin emarhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@niccolomineo niccolomineo changed the title Add ClosestPoint PostGIS function Add ClosestPoint function to GeoDjango Jan 14, 2023
@pauloxnet
Copy link
Contributor

buildbot, test on oracle.

@niccolomineo niccolomineo force-pushed the feature/geodjango-closest-point branch 2 times, most recently from 972bac2 to 5fedb5c Compare January 17, 2023 13:50
carltongibson
carltongibson reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @niccolomineo, thanks for this!

Can you add a release note to the django.contrib.gis section of docs/releases/5.0.txt. (See similar in 4.2.txt for a model.)

@carltongibson carltongibson changed the title Add ClosestPoint function to GeoDjango Fixed #34266 -- Add ClosestPoint function to GeoDjango. Jan 18, 2023
@niccolomineo niccolomineo force-pushed the feature/geodjango-closest-point branch from 5fedb5c to f021405 Compare January 18, 2023 08:27
@niccolomineo
Copy link
Contributor Author

Hi @niccolomineo, thanks for this!

Can you add a release note to the django.contrib.gis section of docs/releases/5.0.txt. (See similar in 4.2.txt for a model.)

Just added!

pauloxnet
pauloxnet approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look to me ready to squash commits and merge.

felixxm
felixxm reviewed Jan 18, 2023
View reviewed changes
docs/releases/5.0.txt Outdated Show resolved Hide resolved
@niccolomineo
Copy link
Contributor Author

@felixxm let me know if anything else is missing.

@felixxm felixxm changed the title Fixed #34266 -- Add ClosestPoint function to GeoDjango. Fixed #34266 -- Added ClosestPoint GIS database functions. Jan 20, 2023
@felixxm felixxm force-pushed the feature/geodjango-closest-point branch from 7a12911 to 1f6df59 Compare January 20, 2023 05:24
@felixxm
Copy link
Member

felixxm commented Jan 20, 2023

@niccolomineo Thanks 👍 Welcome aboard ⛵

I pushed small edits.

@felixxm felixxm force-pushed the feature/geodjango-closest-point branch from 1f6df59 to 79c298c Compare January 20, 2023 07:15
@felixxm felixxm merged commit 79c298c into django:main Jan 20, 2023
@niccolomineo niccolomineo deleted the feature/geodjango-closest-point branch February 3, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson left review comments

@felixxm felixxm felixxm left review comments

@pauloxnet pauloxnet pauloxnet approved these changes

@emarhin emarhin emarhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@niccolomineo @pauloxnet @felixxm @carltongibson @emarhin