Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #32339 -- Deprecated transitional form renderers. #16472

Merged
merged 1 commit into from Jan 18, 2023
Merged

Refs #32339 -- Deprecated transitional form renderers. #16472

merged 1 commit into from Jan 18, 2023

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Jan 18, 2023

No description provided.

@felixxm felixxm requested a review from a team January 18, 2023 08:14
@carltongibson carltongibson changed the title Refs #32339 -- Depracated DjangoDivFormRenderer and Jinja2DivFormRenderer form renderers. Refs #32339 -- Deprecated DjangoDivFormRenderer and Jinja2DivFormRenderer form renderers. Jan 18, 2023
carltongibson
carltongibson approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

hramezani
hramezani approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@hramezani hramezani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@felixxm felixxm changed the title Refs #32339 -- Deprecated DjangoDivFormRenderer and Jinja2DivFormRenderer form renderers. Refs #32339 -- Deprecated transitional form renderers. Jan 18, 2023
@felixxm
Copy link
Member Author

felixxm commented Jan 18, 2023

Thanks for reviews 👍

@felixxm felixxm merged commit b209518 into django:main Jan 18, 2023
@felixxm felixxm deleted the refs-32339-deprecate branch January 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

@hramezani hramezani hramezani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@felixxm @carltongibson @hramezani