Fixed #34370 -- Added integer fields validation as 64-bit on SQLite. #16601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
felixxm
reviewed
Feb 27, 2023
|
|
||
| with self.assertRaises(ValidationError): | ||
| instance_overflow.full_clean() | ||
| instance_underflow.full_clean() |
nabil-rady
force-pushed
the
ticket_34370
branch
from
85e0718
to
2083ff4
Compare
felixxm
reviewed
Feb 28, 2023
| instance = self.model(value=min_value) | ||
| instance.full_clean() | ||
| instance.save() | ||
| qs = self.model.objects.filter(value__lte=min_value) | ||
| self.assertEqual(qs.count(), 1) | ||
| self.assertEqual(qs[0].value, min_value) | ||
|
|
||
| if max_value is not None: | ||
| if max_value <= max_documented_value: |
There was a problem hiding this comment.
Changes in test_backend_range_save looks unnecessary, please revert.
| instance_underflow.full_clean() | ||
| instance_overflow = self.model(value=max_value + 1) | ||
| with self.assertRaises(ValidationError): | ||
| instance_overflow.full_clean() |
There was a problem hiding this comment.
test_overflow_and_underflow seems unnecessary, it's already tested in test_backend_range_validation.
felixxm
reviewed
Mar 1, 2023
nabil-rady
force-pushed
the
ticket_34370
branch
3 times, most recently
from
5a5cb3d
to
d3ffdc7
Compare
felixxm
changed the title
felixxm
reviewed
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 34370