Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #34383 -- Corrected margins in admin fieldsets with multiple fields on the same line on small screens. #16702

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Refs #34383 -- Corrected margins in admin fieldsets with multiple fields on the same line on small screens. #16702

merged 1 commit into from
Mar 29, 2023

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Mar 29, 2023

Regression in d687feb.

Before:

before

After:

after

@felixxm
Copy link
Member Author

felixxm commented Mar 29, 2023

JavaScript tests failure is not related, see #16700.

@felixxm felixxm requested a review from knyghty March 29, 2023 11:21
knyghty
knyghty approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@knyghty knyghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💚

@felixxm felixxm requested a review from a team March 29, 2023 11:46
smithdc1
smithdc1 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@smithdc1 smithdc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Looks like we should allow the accessibility team to also approve mergers PRs.

@felixxm
Copy link
Member Author

felixxm commented Mar 29, 2023

Thanks both for checking 👍

@felixxm
Refs #34383 -- Corrected margins in admin fieldsets with multiple fie…
affa3b0 
…lds on the same line on small screens.

Regression in d687feb.
@felixxm felixxm merged commit b347dc6 into django:main Mar 29, 2023
@felixxm felixxm deleted the small-screen-fieldset branch March 29, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knyghty knyghty knyghty approved these changes

@smithdc1 smithdc1 smithdc1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@felixxm @knyghty @smithdc1