Fixed #34459 -- Fixed SearchVector() crash for parameters with % characters. #16731
Conversation
felixxm
force-pushed
the
issur-34459
branch
4 times, most recently
from
47ba207
to
69c6695
Compare
| # These parameters must be bound on the client side because we may | ||
| # want to create an index on this expression. | ||
| sql = connection.ops.compose_sql(sql, config_params + params + extra_params) | ||
| return sql, [] |
There was a problem hiding this comment.
This was only necessary for a single test postgres_tests.test_search.SearchVectorIndexTests.test_search_vector_index, however test_search_vector_index didn't cover the way how Django handles creating new constraints. It was a temporary and bit clunky way to create a regression test.
There was a problem hiding this comment.
Ah in the end you found a nice result 👍
felixxm
changed the title
Thanks Patryk Zawadzki for the report. Regression in 09ffc5c.
|
@patrys Does it work for you? |
|
@felixxm while I did not test this PR specifically, I have an identical fix in my project branch, where I copied the entire |
Thanks 👍 |
| # These parameters must be bound on the client side because we may | ||
| # want to create an index on this expression. | ||
| sql = connection.ops.compose_sql(sql, config_params + params + extra_params) | ||
| return sql, [] |
There was a problem hiding this comment.
Ah in the end you found a nice result 👍
|
Thanks y'all for reviews 👍 |
Thanks Patryk Zawadzki for the report.
Regression in 09ffc5c.
TO DO:
test for creating and index with(already tested inSearchVectorpostgres_tests.test_search.SearchVectorIndexTests.test_search_vector_index)addEDIT: unnecessary as composed options are passed in params)adapt_value()topsycopg_anyand use it inSearchHeadline.as_sql()