Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34484, Fixed #34482 -- Fixed cloning/deep cloning HttpRequest, HttpResponse, and their subclasses. #16755

Merged
merged 2 commits into from Apr 12, 2023
Merged

Fixed #34484, Fixed #34482 -- Fixed cloning/deep cloning HttpRequest, HttpResponse, and their subclasses. #16755

merged 2 commits into from Apr 12, 2023

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Apr 12, 2023

ticket-34482
ticket-34484

Regressions in d7f5bfd and 6220c44.

Thanks Adam Johnson and Márton Salomváry for reports.

@felixxm felixxm requested a review from a team April 12, 2023 08:02
@felixxm felixxm mentioned this pull request Apr 12, 2023
Closed
@felixxm felixxm requested a review from adamchainz April 12, 2023 08:10
adamchainz
adamchainz reviewed Apr 12, 2023
View reviewed changes
tests/requests_tests/tests.py Outdated Show resolved Hide resolved
tests/requests_tests/tests.py Outdated Show resolved Hide resolved
tests/requests_tests/tests.py Show resolved Hide resolved
@felixxm
Fixed #34484, Refs #34482 -- Reverted "Fixed #29186 -- Fixed pickling…
35c47d5 
… HttpRequest and subclasses."

This reverts commit 6220c44.

Thanks Adam Johnson and Márton Salomváry for reports.
@felixxm
Refs #34482 -- Reverted "Fixed #32969 -- Fixed pickling HttpResponse …
44fe08b 
…and subclasses."

This reverts commit d7f5bfd.

Thanks Márton Salomváry for the report.
@felixxm
Copy link
Member Author

felixxm commented Apr 12, 2023

@adamchainz Thanks 👍 updated.

@adamchainz
Copy link
Sponsor Member

Hopefully, we can restore picklea-bility in the future, but it will need to pass the new tests.

nessita
nessita approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@felixxm
Copy link
Member Author

felixxm commented Apr 12, 2023

Thanks both for checking 👍

@felixxm felixxm merged commit 173034b into django:main Apr 12, 2023
26 checks passed
@felixxm felixxm deleted the issue-34484 branch April 12, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nessita nessita nessita approved these changes

@adamchainz adamchainz adamchainz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@felixxm @adamchainz @nessita