Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #34496 -- Fixed handling source maps with data URI in ManifestStaticFilesStorage. #16780

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

hwalinga
Copy link
Contributor

Fixes https://code.djangoproject.com/ticket/34496

The PR also includes an example as a test case.

@felixxm felixxm changed the title Fix set matched regex group correctly Fixed #34496 -- Fixed handling source maps with data URI in ManifestStaticFilesStorage. Apr 20, 2023
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hwalinga Thanks 👍

tests/staticfiles_tests/project/documents/cached/module.js Outdated Show resolved Hide resolved
tests/staticfiles_tests/test_storage.py Outdated Show resolved Hide resolved
django/contrib/staticfiles/storage.py Show resolved Hide resolved
@felixxm felixxm self-assigned this Apr 20, 2023
@felixxm felixxm force-pushed the fix-set-matched-regex-group-correctly branch from f063a3b to ea2d88e Compare April 21, 2023 03:39
@felixxm
Copy link
Member

felixxm commented Apr 21, 2023

@hwalinga Thanks 👍 Welcome aboard ⛵

@felixxm felixxm force-pushed the fix-set-matched-regex-group-correctly branch from ea2d88e to fb535e0 Compare April 21, 2023 03:42
@felixxm felixxm merged commit fb535e0 into django:main Apr 21, 2023
24 checks passed
@hwalinga
Copy link
Contributor Author

@felixxm Great!

As this is actually a software regression (this bug was not present in 3.2 and is in 4.2), should it also be backported to the 4.2 branch?

@felixxm
Copy link
Member

felixxm commented Apr 22, 2023

As this is actually a software regression (this bug was not present in 3.2 and is in 4.2), should it also be backported to the 4.2 branch?

This is a regression in Django 4.0, but it was reported when Django 4.0 was no longer supported, per our backporting policy this means it doesn't qualify for a backport to 4.0.x, 4.1.x, or 4.2.x anymore. See Django’s release process for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants