Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #34568 -- Made makemigrations --update respect --name option. #16865

Merged
merged 1 commit into from May 17, 2023

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented May 17, 2023

Thanks David Sanders for the report.

ticket-34568

@felixxm felixxm requested a review from a team May 17, 2023 07:07
Copy link
Contributor

@shangxiao shangxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍

Are we updating the docs as part of this to mention that the name isn't preserved, instead auto generated per usual and to keep the name one must use --name ?

Edit: isn't preserved

@felixxm
Copy link
Member Author

felixxm commented May 17, 2023

Are we updating the docs as part of this to mention that the name isn't preserved, instead auto generated per usual and to keep the name one must use --name ?

Edit: isn't preserved

I added a short note.

@felixxm
Copy link
Member Author

felixxm commented May 17, 2023

@shangxiao Thanks for checking 👍

@felixxm felixxm merged commit c52f429 into django:main May 17, 2023
26 checks passed
@felixxm felixxm deleted the issue-34568 branch May 17, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants