Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #34616 -- Corrected label examples in 5.0 release notes. #16912

Merged
merged 1 commit into from Jun 1, 2023

Conversation

cc-a
Copy link
Contributor

@cc-a cc-a commented Jun 1, 2023

Swapped references to .label to .label_tag in 5.0 release notes in the form field rendering code example.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@cc-a cc-a changed the title Fixed code example in 5.0 release notes Fixed #34616 -- Fixed code example in 5.0 release notes Jun 1, 2023
@felixxm felixxm changed the title Fixed #34616 -- Fixed code example in 5.0 release notes Fixed #34616 -- Corrected label examples in 5.0 release notes. Jun 1, 2023
Copy link
Member

@smithdc1 smithdc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@felixxm
Copy link
Member

felixxm commented Jun 1, 2023

@cc-a Thanks for the patch 👍 Welcome aboard ⛵

CI failure is not related.

@felixxm felixxm merged commit 24d56e2 into django:main Jun 1, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants