Fixed #33143 -- Raised RuntimeWarning when performing import-time queries. #16923
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
PoByBolek
force-pushed
the
main
branch
6 times, most recently
from
402b19f
to
4da05ac
Compare
PoByBolek
force-pushed
the
main
branch
3 times, most recently
from
273a6e3
to
26fc2f9
Compare
|
@felixxm thanks for the review! I left a few questions to some of your comments. Could you have another look please? |
PoByBolek
force-pushed
the
main
branch
2 times, most recently
from
b342e9f
to
ea2afa9
Compare
There was a problem hiding this comment.
@PoByBolek Thanks for updates 👍 Looks great, we're almost there.
PoByBolek
force-pushed
the
main
branch
3 times, most recently
from
e8f0ad9
to
18e64b6
Compare
|
@felixxm Is there something weird going on with Jenkins? It keeps building commit 927a54a from three weeks ago. So it doesn't execute any of the new tests. Not even those that should fail on purpose... Is this because of the conflict in
|
|
Just a small process question: should I squash and rebase my commits onto the current |
You can squash & rebase, or only rebase and I will squash when making final edits. |
felixxm
changed the title
There was a problem hiding this comment.
@PoByBolek Thanks 👍 Welcome aboard ⛵
I pushed small edits and added tests for executemany().
Ticket #33143