New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #34627 -- Highlighted active row in admin UI when forced-colors mode is enabled. #16932
Conversation
Thank you for this work! For those (like me) that had no idea how to test this in Firefox, I followed https://hacks.mozilla.org/2020/07/adding-prefers-contrast-to-firefox/ and set the colors to "Override the colors specified by the page with your selections above" -> "Always". I used the default colors from Firefox, and this is how it looks: I was wondering if the row highlight could be... ligther? different? so the text on the highlighted row is easier to read. Right now the bold violet on top of dark cyan (?) seems challenging. EDIT: After some googling (I'm not CSS expert), it seems that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since this is working as expected, will wait a few days before merging to ensure other reviewers get the chance to review as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for giving this a go @nmenezes0. Result is looking great.
Thanks for all your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmenezes0 Thanks 👍
Fixes https://code.djangoproject.com/ticket/34627
This PR adds highlighting on selected models in the admin sidebar and changelist when using "forced-colors".
For selected models in the admin and changelist:
This is what you currently see with forced-colors:
This PR changes this to: