Fixed #24472 -- Defined internal types explicitly for related fields

[Akash-Kumar-Sen]

Ticket - 24472
Following PR #4296

[shangxiao]

I'm not sure I see the point of adding extra boilerplate like this as the name of the field can be determined from the class; and the fact that the ticket & PR never got updated to add some simple tests over the last decade tells me that nobody has a use for it.

If we really wanted this for consistency's sake we can do this:

class OneToOneField:
    @classmethod
    def get_internal_type(cls):
        return cls.__name__

gives:

>>> field = OneToOneField()
>>> field.get_internal_type()
'OneToOneField'
>>> OneToOneField().get_internal_type()
'OneToOneField'

[Akash-Kumar-Sen]

• I also don't see any other reason than consistency.
• Deriving the string from using cls.__name__ makes more sense rather than hardcoding it. But that won't work on Inherited fields.

[felixxm]

If we really wanted this for consistency's sake we can do this:

class OneToOneField:
    @classmethod
    def get_internal_type(cls):
        return cls.__name__

gives:

>>> field = OneToOneField()
>>> field.get_internal_type()
'OneToOneField'
>>> OneToOneField().get_internal_type()
'OneToOneField'

It works this way from the very beginning:

django/django/db/models/fields/__init__.py

Lines 973 to 974 in b81e974

	def get_internal_type(self):
	return self.__class__.__name__

[felixxm]

Closing per ticket.