Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #34675 -- Fixed creating remote webdriver for Selenium 4.10.0+. #17001

Merged
merged 1 commit into from Jun 26, 2023

Conversation

hansegucker
Copy link
Contributor

In Selenium 4, the old way of setting capabilities for remote web drivers was deprecated.

In Selenium 4, the old way of setting capabilities for remote
web drivers was deprecated.
@hansegucker
Copy link
Contributor Author

The bug can be reproduced using a current Selenium version and running Selenium remotely.

e. g. with ./runtests.py --selenium firefox --selenium-hub http://127.0.0.1:4444/wd/hub --external-host 172.17.0.1 (using docker-selenium)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@sarahboyce sarahboyce added the selenium Apply to have Selenium tests run on a PR label Jun 23, 2023
@nessita
Copy link
Contributor

nessita commented Jun 23, 2023

buildbot, test on selenium.

Thank you Sarah!

@django django deleted a comment from nessita Jun 23, 2023
@felixxm felixxm changed the title Fixed #34675 -- Fixed setting of capabilities for Selenium. Fixed #34675 -- Fixed creating remote webdriver for Selenium 4.10.0+. Jun 23, 2023
@felixxm felixxm self-assigned this Jun 26, 2023
@felixxm
Copy link
Member

felixxm commented Jun 26, 2023

@hansegucker Thanks 👍 Welcome aboard ⛵

@felixxm felixxm merged commit ecd5a0d into django:main Jun 26, 2023
30 checks passed
@hansegucker
Copy link
Contributor Author

@hansegucker Thanks 👍 Welcome aboard ⛵

You're welcome! I am glad that I could help. Does this get any backporting to the 4.x.x series?

@felixxm
Copy link
Member

felixxm commented Jun 26, 2023

Does this get any backporting to the 4.x.x series?

Unfortunately not, we don't backport cleanups of new features. See Django’s release process for more details.

@hansegucker
Copy link
Contributor Author

Does this get any backporting to the 4.x.x series?

Unfortunately not, we don't backport cleanups of new features. See Django’s release process for more details.

Ok, I thought of this as a bug fix in the first way. But it actually seems to be supporting a newer version of Selenium with dropping support for old versions of Selenium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
selenium Apply to have Selenium tests run on a PR
Projects
None yet
4 participants