Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34676 -- Normalized Distance()/Area() exceptions for nonexistent units. #17006

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fixed #34676 -- Normalized Distance()/Area() exceptions for nonexistent units. #17006

merged 1 commit into from
Jun 26, 2023

Conversation

anorthall
Copy link
Contributor

Fixes 34676.

@anorthall anorthall changed the title Fixed #34676 - Add DistanceUnitDoesNotExist exception and tests for it Fixed #34676 - Normalise all unit not found exceptions to use AttributeError Jun 24, 2023
felixxm
felixxm reviewed Jun 25, 2023
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anorthall Thanks 👍 I pushed small edits.

@felixxm felixxm changed the title Fixed #34676 - Normalise all unit not found exceptions to use AttributeError Fixed #34676 -- Normalized Distance()/Area() exceptions for nonexistent units. Jun 25, 2023
@felixxm felixxm merged commit 38cde27 into django:main Jun 26, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@anorthall @felixxm