Fixed #34679 - Lazy load staticfiles manifest #17015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
reviewed
Jun 26, 2023
Comment on lines
469
to
479
| self._hashed_files = self.load_manifest()[0] | ||
| return self._hashed_files | ||
|
|
||
| @hashed_files.setter | ||
| def hashed_files(self, value): | ||
| self._hashed_files = value | ||
|
|
||
| @property | ||
| def manifest_hash(self): | ||
| if self._manifest_hash is None: | ||
| self._manifest_hash = self.load_manifest()[1] |
There was a problem hiding this comment.
Isn't this going to cause the manifest to be loaded twice if both properties are accessed?
What about
Suggested change
| self._hashed_files = self.load_manifest()[0] | |
| return self._hashed_files | |
| @hashed_files.setter | |
| def hashed_files(self, value): | |
| self._hashed_files = value | |
| @property | |
| def manifest_hash(self): | |
| if self._manifest_hash is None: | |
| self._manifest_hash = self.load_manifest()[1] | |
| self._hashed_files, self._manifest_hash = self.load_manifest() | |
| return self._hashed_files | |
| @hashed_files.setter | |
| def hashed_files(self, value): | |
| self._hashed_files = value | |
| @property | |
| def manifest_hash(self): | |
| if self._manifest_hash is None: | |
| self._hashed_files, self._manifest_hash = self.load_manifest() |
There was a problem hiding this comment.
Good catch, thanks!
Fixed collectstatic when unsupported manifest file already exists.
jwygoda
force-pushed
the
34679/lazy-staticfiles-manifest
branch
from
5d2bb8f
to
fa26109
Compare
|
Closing per ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed collectstatic when unsupported manifest file already exists.