Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #34572 -- Added support for GDAL 3.7. #17024

Merged
merged 1 commit into from Jun 30, 2023
Merged

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Jun 29, 2023

self.assertEqual(
compressed.bands[0].metadata["IMAGE_STRUCTURE"]["PIXELTYPE"],
"SIGNEDBYTE",
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out docs:

"Starting with GDAL 3.7, this metadata item is no longer used, as the Int8 data type is used for signed bytes."

@smithdc1
Copy link
Member

I see one failing test, but I think it's not related to this change. I think it's related to 1b754d6

======================================================================
FAIL: test_centroid_collect_filter (gis_tests.relatedapp.tests.RelatedGeoModelTest.test_centroid_collect_filter)
----------------------------------------------------------------------
AssertionError: 'POINT (3.2127999999999997 1.5000000000000002)' != 'POINT (3.2128 1.5)'
- POINT (3.2127999999999997 1.5000000000000002)
+ POINT (3.2128 1.5)

I tested with:

proj==9.2.0
gdal==3.7.0
geos==3.11.2
libspatialite==5.0.1

Copy link
Member

@smithdc1 smithdc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- couple small questions below.

docs/ref/contrib/gis/install/geolibs.txt Outdated Show resolved Hide resolved
tests/gis_tests/gdal_tests/test_raster.py Outdated Show resolved Hide resolved
Co-Authored-By: Michael Howitz <mh@gocept.com>
@felixxm
Copy link
Member Author

felixxm commented Jun 30, 2023

@smithdc1 Thanks for the review ⭐

I see one failing test, but I think it's not related to this change. I think it's related to 1b754d6

Yes, it's not related I have the same error with GDAL 3.5 and 3.6, will fix it separately.

@felixxm
Copy link
Member Author

felixxm commented Jun 30, 2023

Yes, it's not related I have the same error with GDAL 3.5 and 3.6, will fix it separately.

@felixxm felixxm merged commit 953f29f into django:main Jun 30, 2023
28 checks passed
@felixxm felixxm deleted the issue-34572 branch June 30, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants