Refs #31949 -- Made @vary_on_(cookie/headers) decorators work with async functions. #17056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LomaxOnTheRun
force-pushed
the
async-vary-decorators
branch
from
e1a0584
to
5eea2dc
Compare
felixxm
reviewed
Jul 10, 2023
felixxm
force-pushed
the
async-vary-decorators
branch
from
5eea2dc
to
b7a17b0
Compare
felixxm
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
@LomaxOnTheRun Thanks 👍
I squashed commits, rebased after fb1c763, and simplified tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to #31949.
This PR makes the
vary_on_cookieandvary_on_headersdecorators able to handle both sync and async views.