Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified call_command() calls. #17115

Merged
merged 1 commit into from Jul 27, 2023
Merged

Conversation

ngnpope
Copy link
Member

@ngnpope ngnpope commented Jul 27, 2023

A smattering of small clean ups related to django.core.management.call_command().

@ngnpope ngnpope requested a review from felixxm July 27, 2023 08:51
@ngnpope ngnpope changed the title Simplified call syntax and fixed documentation for call_command(). Simplified call syntax and tidied documentation for call_command(). Jul 27, 2023
@ngnpope
Copy link
Member Author

ngnpope commented Jul 27, 2023

(Test failure is unrelated.)

@nessita
Copy link
Contributor

nessita commented Jul 27, 2023

Hi @ngnpope! Thank you for this tidy up. Would you consider splitting the doc changes from the rest? That way, the docs changes would be more easily landable since we backport those. OTOH, since we don't backport other changes, that split will certainly help in the review and merging process. Thank you!

@felixxm
Copy link
Member

felixxm commented Jul 27, 2023

Would you consider splitting the doc changes from the rest? That way, the docs changes would be more easily landable since we backport those.

Docs changes are only minor cleanups, there is no need to backport them.

@felixxm felixxm changed the title Simplified call syntax and tidied documentation for call_command(). Simplified call_command() calls. Jul 27, 2023
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngnpope Thanks 👍 I dropped the commit with the changes in parentheses.

@felixxm felixxm merged commit 89c8c2e into django:main Jul 27, 2023
35 checks passed
@ngnpope ngnpope deleted the tidy-call-mgmt-cmd branch July 27, 2023 16:13
@felixxm felixxm temporarily deployed to schedules July 28, 2023 02:44 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants