Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed call read before call body #17139

Closed
wants to merge 1 commit into from
Closed

Fixed call read before call body #17139

wants to merge 1 commit into from

Conversation

runtangr
Copy link

@runtangr runtangr commented Aug 3, 2023

  1. request obj call read function, self._read_started = True
  2. request obj call body function, request obj don't have _body, but self._read_started = True.
    the You cannot access body after reading from request's data stream exception will raise

so, I add _body in read function.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@runtangr
Copy link
Author

runtangr commented Aug 3, 2023

I get it

# Because multipart is used for large amounts of data i.e. file uploads,
# we don't want the data held in memory twice, and we don't want to
# silence the error by setting body = '' either.

@runtangr runtangr closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant