Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34761 -- Dropped support for MySQL < 8.0.11. #17140

Merged
merged 1 commit into from Aug 3, 2023
Merged

Fixed #34761 -- Dropped support for MySQL < 8.0.11. #17140

merged 1 commit into from Aug 3, 2023

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Aug 3, 2023

ngnpope
ngnpope approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor tweak.

django/db/backends/mysql/features.py Outdated Show resolved Hide resolved
@felixxm
Copy link
Member Author

felixxm commented Aug 3, 2023

@ngnpope Thanks for checking 👍

nessita
nessita approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixxm
Copy link
Member Author

felixxm commented Aug 3, 2023

Thanks both for checking 👍

@felixxm felixxm merged commit b719688 into django:main Aug 3, 2023
28 checks passed
@felixxm felixxm deleted the issue-34761 branch August 3, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nessita nessita nessita approved these changes

@ngnpope ngnpope ngnpope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@felixxm @nessita @ngnpope