Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34739 -- Added GEOSGeometry.equals_identical() method. #17146

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Fixed #34739 -- Added GEOSGeometry.equals_identical() method. #17146

merged 1 commit into from
Aug 5, 2023

Conversation

olibook
Copy link
Contributor

@olibook olibook commented Aug 4, 2023 •
edited

Implements #34739

GEOSEqualsIdentical compares two geometries and returns True if they are pointwise equivalent.

felixxm
felixxm reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olibook Thanks for this patch 👍 I left comments.

tests/gis_tests/geos_tests/test_geos.py Outdated Show resolved Hide resolved
tests/gis_tests/geos_tests/test_geos.py Outdated Show resolved Hide resolved
docs/releases/5.0.txt Outdated Show resolved Hide resolved
docs/releases/5.0.txt Outdated Show resolved Hide resolved
tests/gis_tests/geos_tests/test_geos.py Outdated Show resolved Hide resolved
docs/ref/contrib/gis/geos.txt Show resolved Hide resolved
@olibook olibook marked this pull request as draft August 4, 2023 10:41
@olibook olibook marked this pull request as ready for review August 4, 2023 14:08
@olibook
Copy link
Contributor Author

olibook commented Aug 4, 2023

Hi @felixxm thank you for your review. I made a few edits to address your comments.

@felixxm felixxm changed the title Fixed #34739 -- Implemented GEOSEqualsIdentical method Fixed #34739 -- Added GEOSGeometry.equals_identical() method. Aug 5, 2023
@felixxm
Copy link
Member

felixxm commented Aug 5, 2023

@olibook Thanks for updates 👍 I pushed small final edits.

@olibook
Copy link
Contributor Author

olibook commented Aug 5, 2023

@olibook Thanks for updates 👍 I pushed small final edits.

@felixxm
enchant prefers "point-wise" to "pointwise". No idea which one is correct

@felixxm
Copy link
Member

felixxm commented Aug 5, 2023

@olibook Thanks for updates +1 I pushed small final edits.

@felixxm enchant prefers "point-wise" to "pointwise". No idea which one is correct

Reverted.

@felixxm felixxm merged commit 0f3b1a7 into django:main Aug 5, 2023
35 checks passed
@olibook olibook deleted the ticket_34739 branch August 5, 2023 20:52
@felixxm felixxm temporarily deployed to schedules August 6, 2023 02:44 — with GitHub Actions Inactive
@felixxm felixxm temporarily deployed to schedules August 7, 2023 02:44 — with GitHub Actions Inactive
@felixxm felixxm temporarily deployed to schedules August 8, 2023 02:44 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@olibook @felixxm