Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #34757 -- Added support for following redirects to AsyncClient. #17168

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

olibook
Copy link
Contributor

@olibook olibook commented Aug 16, 2023

Fix for https://code.djangoproject.com/ticket/34757

Did my best to factor the "follow redirect" logic and prevent code duplication.

Cheers

@olibook olibook force-pushed the ticket_34757 branch 2 times, most recently from a2314cc to d9f86ce Compare August 18, 2023 20:54
@olibook olibook marked this pull request as ready for review August 18, 2023 21:07
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olibook Thanks 👍 I left comments.

django/test/client.py Outdated Show resolved Hide resolved
django/test/client.py Outdated Show resolved Hide resolved
django/test/client.py Outdated Show resolved Hide resolved
django/test/client.py Outdated Show resolved Hide resolved
@olibook olibook force-pushed the ticket_34757 branch 2 times, most recently from 493de96 to 31ab697 Compare August 29, 2023 16:07
tests/test_client/tests.py Outdated Show resolved Hide resolved
@felixxm felixxm changed the title Fixed #34757 -- Made AsyncClient follow redirects Fixed #34757 -- Added support for following redirects to AsyncClient. Aug 30, 2023
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olibook Thanks 👍

@felixxm felixxm merged commit 3f8dbe2 into django:main Aug 30, 2023
35 checks passed
@olibook olibook deleted the ticket_34757 branch August 30, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants