Allow ssh URLs to pass URLValidator #1717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you're not aware, pull requests without a corresponding Trac ticket are ignored per our contributing guidelines. I see ftp was added in ticket #15229. I'm inclined to say that most users probably expect http(s) and that if you need other schemes you should write a custom validator, but if you open a ticket we can get some other opinions. Assuming this had an accepted ticket, we should document what schemes are supported. |
The generic definition of Uniform Resource Locator doesn't include any restriction on the scheme, so Django's URLValidator should at least accept the most common ones. This includes ssh://. Refs #21242 -- Allow more IANA schemes in URLValidator
|
Oh, I'm sorry. So I filed a (slightly broader) ticket and added "refs #xxx -- yyy" to the commit message. |
|
Please see the approach suggested in the ticket and send a new PR if you can make those adjustments, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic definition of Uniform Resource Locator doesn't include any
restriction on the scheme, so Django's URLValidator should at least
accept the most common ones. This includes ssh://.
Refs #21242 -- Allow more IANA schemes in URLValidator