Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34709 -- Raised BadRequest for form-urlencoded requests declaring a non-UTF-8 encoding. #17184

Merged
merged 1 commit into from Aug 25, 2023
Merged

Fixed #34709 -- Raised BadRequest for form-urlencoded requests declaring a non-UTF-8 encoding. #17184

merged 1 commit into from Aug 25, 2023

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Aug 22, 2023

ticket-34709

Thanks Eki Xu for the report.

nessita
nessita reviewed Aug 23, 2023
View reviewed changes
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added questions/suggestions!

django/http/request.py Outdated Show resolved Hide resolved
tests/requests_tests/tests.py Outdated Show resolved Hide resolved
@nessita nessita changed the title Fixed #34709 -- Raised BadRequest for non-UTF-8 requests with the application/x-www-form-urlencoded content type. Fixed #34709 -- Raised BadRequest for form-urlencoded requests declaring a non-UTF-8 encoding. Aug 23, 2023
@felixxm
Fixed #34709 -- Raised BadRequest for non-UTF-8 requests with the app…
4ac67a8 
…lication/x-www-form-urlencoded content type.

Thanks Eki Xu for the report.
@felixxm
Copy link
Member Author

felixxm commented Aug 23, 2023

@nessita Thanks for the review 👍

@felixxm felixxm requested a review from claudep August 23, 2023 11:09
nessita
nessita approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@nessita nessita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

@felixxm felixxm merged commit 11920e7 into django:main Aug 25, 2023
28 checks passed
@felixxm felixxm deleted the issue-34709 branch August 25, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nessita nessita nessita approved these changes

@claudep claudep Awaiting requested review from claudep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@felixxm @nessita