Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34858 -- Corrected resolving output_field for PositiveIntegerField. #17299

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fixed #34858 -- Corrected resolving output_field for PositiveIntegerField. #17299

merged 1 commit into from
Sep 22, 2023

Conversation

Toad2186
Copy link
Contributor

  • Math operations involving two PositiveIntegerFields should resolve to an output of PositiveIntegerField instead of an IntegerField. This was a regression introduced in ticket #33397.
  • Add my name to AUTHORS.

@felixxm felixxm changed the title Fixed #34858 -- Fix output_field resolution for PositiveIntegerField Fixed #34858 -- Corrected resolving output_field for PositiveIntegerField. Sep 22, 2023
felixxm
felixxm approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Toad2186 Thanks 👍 Welcome aboard ⛵

I simplified tests a bit.

@felixxm felixxm merged commit 4de31ec into django:main Sep 22, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Toad2186 @felixxm