Fixed #7603 -- Added a 'scheme' property to the HttpRequest object #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although the tests are passing, I think this patch is problematic in that |
`HttpRequest.scheme` is `https` if `settings.SECURE_PROXY_SSL_HEADER` appropriately set, falls back to `HttpRequest._get_scheme()` (a hook for subclasses to implement) otherwise. `WSGIRequest._get_scheme()` makes use of `wsgi.url_scheme` WSGI environ variable to determine the request scheme. `HttpRequest.is_secure()` not simply checks if `HttpRequest.scheme` is `https`. This provides a handful method to check for current scheme in, for example, templates. It also allows to deal with other schemes.
|
Please @timgraham check the new commit. |
|
merged in c7634cd - thanks! one note: I found some trailing whitespace in your patch that I removed. You may want to configure your editor to remove that if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpRequest.scheme uses self.is_secure() to determine if scheme is
'http' or 'https' wether WSGIRequest.scheme makes use of the
'wsgi.url_scheme' WSGI environ variable.
This provides a handful method to check for current scheme in, for
example, templates. It also allows to deal with other schemes.