Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34877 -- Fixed migrations crash when adding GeneratedField with output_field with params. #17314

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fixed #34877 -- Fixed migrations crash when adding GeneratedField with output_field with params. #17314

merged 1 commit into from
Sep 28, 2023

Conversation

pauloxnet
Copy link
Contributor

@pauloxnet pauloxnet commented Sep 27, 2023 •
edited

@pauloxnet pauloxnet marked this pull request as ready for review September 27, 2023 20:25
@felixxm felixxm changed the title Fixed #34877 -- Add db_type_parameters override Fixed #34877 -- Fixed migrations crash when adding GeneratedField with output_field with params. Sep 28, 2023
felixxm
felixxm reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pauloxnet Thanks 👍

tests/model_fields/test_generatedfield.py Outdated Show resolved Hide resolved
tests/model_fields/test_generatedfield.py Outdated Show resolved Hide resolved
@felixxm felixxm merged commit e7e8eb4 into django:main Sep 28, 2023
31 checks passed
@felixxm felixxm temporarily deployed to schedules September 29, 2023 02:44 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pauloxnet @felixxm