Fixed #34882 -- Fixed no options in AsGeoJSON() for geometries in non-default CRS.

[3nids]

When calling AssGeoJSON, if bbox and crs are both false, then options = 0, there fore not added to the expression.

In Postgis, with geometries, the default is not 0 but 8, meaning the CRS is returned, not respecting the original call arguments.

fixes #34882 https://code.djangoproject.com/ticket/34882#ticket

[github-actions]

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

[felixxm]

@3nids Thanks 👍 Please add a regression test.

[felixxm]

@3nids Do you have time to keep working on this?

[3nids]

I'm a rookie in the code, but I can give it a shot. Could you point me to a similar case in the tests?

[felixxm]

We could add a test for geometry with non-default crs and check an expected JSON format, e.g.

diff --git a/tests/gis_tests/geoapp/test_functions.py b/tests/gis_tests/geoapp/test_functions.py
index e9e2a5dcae..91441bf90c 100644
--- a/tests/gis_tests/geoapp/test_functions.py
+++ b/tests/gis_tests/geoapp/test_functions.py
@@ -11,7 +11,7 @@ from django.db.models import IntegerField, Sum, Value
 from django.test import TestCase, skipUnlessDBFeature
 
 from ..utils import FuncTestMixin
-from .models import City, Country, CountryWebMercator, State, Track
+from .models import City, Country, CountryWebMercator, ManyPointModel, State, Track
 
 
 class GISFunctionsTests(FuncTestMixin, TestCase):
@@ -119,6 +119,25 @@ class GISFunctionsTests(FuncTestMixin, TestCase):
                 chicago_json,
             )
 
+    @skipUnlessDBFeature("has_AsGeoJSON_function")
+    def test_asgeojson_option_0(self):
+        p1 = Point(1, 1, srid=4326)
+        p2 = Point(2, 2, srid=4326)
+        obj = ManyPointModel.objects.create(
+            point1=p1,
+            point2=p2,
+            point3=p2.transform(3857, clone=True),
+        )
+        self.assertJSONEqual(
+            ManyPointModel.objects.annotate(geojson=functions.AsGeoJSON("point3"))
+            .get(pk=obj.pk)
+            .geojson,
+            # GeoJSON without CRS.
+            json.loads(
+                '{"type":"Point","coordinates":[222638.98158655,222684.20850554]}'
+            ),
+        )
+
     @skipUnlessDBFeature("has_AsGML_function")
     def test_asgml(self):
         # Should throw a TypeError when trying to obtain GML from a

[felixxm]

@3nids Check out #17320 (comment).

[3nids]

@felixxm many thanks!!!!

[felixxm]

@3nids Welcome aboard ⛵

[3nids]

@felixxm small question, guessing that main is the current dev branch, is a backport to 4.2.x possible? how is this handled?
cheers!

[felixxm]

guessing that main is the current dev branch, is a backport to 4.2.x possible?

No, it doesn't qualify for a backport to 4.2 based on our supported versions policy.

[3nids]

Oh, pity. Thanks for the feedback!