Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #33647 -- bulk_update silently truncating values for size limied fields(PostgreSQL) #17366

Closed
wants to merge 1 commit into from

Conversation

Akash-Kumar-Sen
Copy link
Contributor

@Akash-Kumar-Sen Akash-Kumar-Sen commented Oct 15, 2023

https://code.djangoproject.com/ticket/33647

Approach : Introduce a new parameter to the Cast() so that we can specify if we do not want to cast charfield with max length.

@felixxm
Copy link
Member

felixxm commented Oct 15, 2023

@Akash-Kumar-Sen Thanks for this patch 👍 However, again, I don't think it's the right approach. First of all, we cannot introduce new keyword arguments into database function that will be only be used to fix usage elsewhere in the Django code. Secondly, not only CharFields are affected.

@Akash-Kumar-Sen
Copy link
Contributor Author

@felixxm left one comment about a new approach on the ticket, let me know what you think about that.

@felixxm
Copy link
Member

felixxm commented Oct 16, 2023

@felixxm left one comment about a new approach on the ticket, let me know what you think about that.

It's really hard to keep track on updates when you split questions/feedback between the ticket and PR.

@felixxm felixxm closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants