Fixed #29850 -- Increased window range support. #17401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
force-pushed
the
ticket_29850_window_support_rowrange_frames
branch
from
851cf78
to
179d1db
Compare
sarahboyce
changed the title
sarahboyce
force-pushed
the
ticket_29850_window_support_rowrange_frames
branch
2 times, most recently
from
7990221
to
c1c3c3b
Compare
sarahboyce
changed the title
sarahboyce
force-pushed
the
ticket_29850_window_support_rowrange_frames
branch
from
c1c3c3b
to
8fe5c0a
Compare
sarahboyce
changed the title
sarahboyce
changed the title
sarahboyce
force-pushed
the
ticket_29850_window_support_rowrange_frames
branch
7 times, most recently
from
5173329
to
029e6ec
Compare
felixxm
reviewed
Oct 26, 2023
felixxm
reviewed
Oct 26, 2023
felixxm
reviewed
Oct 26, 2023
sarahboyce
force-pushed
the
ticket_29850_window_support_rowrange_frames
branch
2 times, most recently
from
3786df9
to
83fc4d3
Compare
felixxm
reviewed
Oct 28, 2023
felixxm
reviewed
Oct 28, 2023
felixxm
reviewed
Oct 28, 2023
felixxm
reviewed
Oct 28, 2023
felixxm
reviewed
Oct 28, 2023
sarahboyce
force-pushed
the
ticket_29850_window_support_rowrange_frames
branch
from
83fc4d3
to
f278478
Compare
felixxm
reviewed
Oct 28, 2023
docs/releases/5.1.txt
Outdated
| @@ -171,6 +171,14 @@ Models | |||
| * :meth:`.QuerySet.explain` now supports the ``generic_plan`` option on | |||
| PostgreSQL 16+. | |||
|
|
|||
| * :class:`~django.db.models.expressions.RowRange` now accept positive integers | |||
There was a problem hiding this comment.
Suggested change
| * :class:`~django.db.models.expressions.RowRange` now accept positive integers | |
| * :class:`~django.db.models.expressions.RowRange` now accepts positive integers |
|
@sarahboyce Thanks 👍 I moved the first commit to the separate PR, #17422. |
…integer end for RowRange.
sarahboyce
force-pushed
the
ticket_29850_window_support_rowrange_frames
branch
from
f278478
to
9ad1c96
Compare
|
Superseded by #17423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://code.djangoproject.com/ticket/29850
startand negative integerendforRowRange.EXCLUDE CURRENT ROW,EXCLUDE GROUP,EXCLUDE TIES,EXCLUDE NO OTHERS(I will push up tweaks while I also figure it out better in my head)