Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #34919 -- Added scope attribute to admindocs model templates. #17455

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jed212
Copy link
Contributor

@jed212 jed212 commented Nov 8, 2023

Added scope to files in Django's admin docs that were lacking the scope attribute. Having this attribute in the table headers makes table navigation easier for screen reader users.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@felixxm felixxm assigned felixxm and unassigned felixxm Nov 8, 2023
@felixxm felixxm requested a review from a team November 8, 2023 10:28
@felixxm
Copy link
Member

felixxm commented Nov 8, 2023

@jed212 Thanks 👍 Please add a regression test for new scope attributes.

@Obinna-Nwankwo

This comment was marked as off-topic.

Copy link
Member

@knyghty knyghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one mistake here but the rest looks good.

@felixxm felixxm changed the title Fixed #34919 -- Added missing scope attribute in admin doc table headers Fixed #34919 -- Added scope attribute to admindocs model templates. Nov 14, 2023
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jed212 Thanks 👍 Welcome aboard ⛵

I added a small regression test.

@felixxm felixxm merged commit bdf30b9 into django:main Nov 14, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants