Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete sentence in custom model field docs. #17478

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

g-nie
Copy link
Contributor

@g-nie g-nie commented Nov 15, 2023

I was having a read and I noticed an inconsistency in the MyDateField example. When explaining the behavior below the code example, connection.settings_dict is referenced while the code checks on connection.vendor.
(the example was changed here without updating the text below it)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

Copy link
Contributor

@shangxiao shangxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 Thanks for the PR!

@g-nie g-nie requested a review from felixxm November 15, 2023 11:57
@felixxm felixxm changed the title Fix typo in docs/howto/custom-model-fields.txt Removed obsolete sentence in custom model field docs. Nov 15, 2023
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g-nie Thanks 👍 Welcome aboard ⛵

@felixxm felixxm merged commit 36ed45d into django:main Nov 15, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants