Fixed #34971 -- Doc'd additional loggers. #17492
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
timgraham
changed the title
|
2nd Iteration to fix issues, add some details, as well as links to the doc |
| ``django.contrib.gis`` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Logging related to :doc:`contrib/gis/index`, at diverse levels : external GeoSpatial libraries (GEOS, GDAL...), Database Schema and Geometry widget. |
There was a problem hiding this comment.
Could you please wrap lines at 79 cols? (These guidelines are covered here)
| Logging related to :doc:`contrib/gis/index`, at diverse levels : external GeoSpatial libraries (GEOS, GDAL...), Database Schema and Geometry widget. | |
| Logging related to :doc:`contrib/gis/index`, at diverse levels: external | |
| GeoSpatial libraries (GEOS, GDAL...), Database Schema and Geometry widget. |
|
|
||
| Logging related to :doc:`contrib/gis/index`, at diverse levels : external GeoSpatial libraries (GEOS, GDAL...), Database Schema and Geometry widget. | ||
|
|
||
| * In case of a database error the SQL query is added to the log context |
There was a problem hiding this comment.
| * In case of a database error the SQL query is added to the log context | |
| * On database errors, the offending SQL query is added to the log context. |
| ``django.dispatch`` | ||
| ~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Logger used in :doc:`signals`. |
There was a problem hiding this comment.
Another trailing space :-)
| Logger used in :doc:`signals`. | |
| Logger used in :doc:`signals`. |
Also, I'm unsure this is the correct reference, the django.dispatch logger is used by the base Signal class which, besides being used by the built-in signals, is also used by any custom signal a project may implement.
| ``django.contrib.gis`` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
| ``django.contrib.gis`` | |
| ~~~~~~~~~~~~~~~~~~~~~~~ | |
| ``django.contrib.gis`` | |
| ~~~~~~~~~~~~~~~~~~~~~~ |
|
|
||
| Logger used in :doc:`signals`. | ||
|
|
||
| At the ERROR level the logger adds the following extra context : |
There was a problem hiding this comment.
| At the ERROR level the logger adds the following extra context : | |
| At the ERROR level the logger adds the following extra context: |
| ``django.utils.autoreload`` | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Log messages related to the autoreload development feature of Django. |
There was a problem hiding this comment.
| Log messages related to the autoreload development feature of Django. | |
| Log messages related to the autoreload development feature of Django. |
|
@duranbe Do you have time to keep working on this? |
|
Closing due to inactivity and in favor of PR #17646. |
|
Hey ! Sorry not answering before, thank you for closing and switching over to another PR, I would not have time to work on it ;( |
No worries, and thank you for letting us know! |
First iteration to improve the Logging configuration by including those three loggers
https://code.djangoproject.com/ticket/34971
Still need to deep dive more on it, but here is a first draft !